From 745a3802dcc215a50543c9bcfc37f15aaea0cbfc Mon Sep 17 00:00:00 2001 From: lanariel Date: Thu, 20 Feb 2014 09:00:02 +0100 Subject: [PATCH 1/3] touched up SSAO and fixed wireframe rendering in release --- .../GameClient/GameClientState/GameState.cpp | 82 +++++++++---------- .../GameClientState/NetLoadState.cpp | 8 +- Code/OysterGraphics/DllInterfaces/GFXAPI.cpp | 20 +++++ .../Shader/Passes/Light/SSAO.hlsli | 4 +- 4 files changed, 67 insertions(+), 47 deletions(-) diff --git a/Code/Game/GameClient/GameClientState/GameState.cpp b/Code/Game/GameClient/GameClientState/GameState.cpp index 61e1d9fc..763563ff 100644 --- a/Code/Game/GameClient/GameClientState/GameState.cpp +++ b/Code/Game/GameClient/GameClientState/GameState.cpp @@ -89,7 +89,7 @@ bool GameState::Init( SharedStateContent &shared ) Float aspectRatio = gfxOp.Resolution.x / gfxOp.Resolution.y; this->privData->camera.SetPerspectiveProjection( Utility::Value::Radian(90.0f), aspectRatio, 0.1f, 1000.0f ); Graphics::API::SetProjection( this->privData->camera.GetProjectionMatrix() ); - gfxOp.AmbientValue = 2.0f; + gfxOp.AmbientValue = 1.0f; Graphics::API::SetOptions(gfxOp); //tell server ready @@ -193,45 +193,45 @@ bool GameState::Render() }*/ // RB DEBUG render wire frame - //if(this->privData->renderWhireframe) - //{ - // Oyster::Graphics::API::StartRenderWireFrame(); - // - // Oyster::Math3D::Float4x4 translation = Oyster::Math3D::TranslationMatrix(Float3( 0,132, 20)); - // Oyster::Math3D::Float4x4 scale = Oyster::Math3D::ScalingMatrix(Float3( 0.5f, 0.5f, 0.5f)); - // Oyster::Math3D::Float4x4 world = translation * scale; - // Oyster::Graphics::API::RenderDebugCube( world ); - // Oyster::Graphics::API::RenderDebugCube(this->privData->player.getRBWorld()); - // - // staticObject = this->privData->staticObjects->begin(); - // for( ; staticObject != this->privData->staticObjects->end(); ++staticObject ) - // { - // if( staticObject->second->getBRtype() == RB_Type_Cube) - // { - // Oyster::Graphics::API::RenderDebugCube( staticObject->second->getRBWorld()); - // } - // if( staticObject->second->getBRtype() == RB_Type_Sphere) - // { - // Oyster::Graphics::API::RenderDebugSphere( staticObject->second->getRBWorld()); - // } - // } - // - // dynamicObject = this->privData->dynamicObjects->begin(); - // for( ; dynamicObject != this->privData->dynamicObjects->end(); ++dynamicObject ) - // { - // if( dynamicObject->second ) - // { - // if( dynamicObject->second->getBRtype() == RB_Type_Cube) - // { - // Oyster::Graphics::API::RenderDebugCube( dynamicObject->second->getRBWorld()); - // } - // if( dynamicObject->second->getBRtype() == RB_Type_Sphere) - // { - // Oyster::Graphics::API::RenderDebugSphere( dynamicObject->second->getRBWorld()); - // } - // } - // } - //} + if(this->privData->renderWhireframe) + { + Oyster::Graphics::API::StartRenderWireFrame(); + + Oyster::Math3D::Float4x4 translation = Oyster::Math3D::TranslationMatrix(Float3( 0,132, 20)); + Oyster::Math3D::Float4x4 scale = Oyster::Math3D::ScalingMatrix(Float3( 0.5f, 0.5f, 0.5f)); + Oyster::Math3D::Float4x4 world = translation * scale; + Oyster::Graphics::API::RenderDebugCube( world ); + Oyster::Graphics::API::RenderDebugCube(this->privData->player.getRBWorld()); + + staticObject = this->privData->staticObjects->begin(); + for( ; staticObject != this->privData->staticObjects->end(); ++staticObject ) + { + if( staticObject->second->getBRtype() == RB_Type_Cube) + { + Oyster::Graphics::API::RenderDebugCube( staticObject->second->getRBWorld()); + } + if( staticObject->second->getBRtype() == RB_Type_Sphere) + { + Oyster::Graphics::API::RenderDebugSphere( staticObject->second->getRBWorld()); + } + } + + dynamicObject = this->privData->dynamicObjects->begin(); + for( ; dynamicObject != this->privData->dynamicObjects->end(); ++dynamicObject ) + { + if( dynamicObject->second ) + { + if( dynamicObject->second->getBRtype() == RB_Type_Cube) + { + Oyster::Graphics::API::RenderDebugCube( dynamicObject->second->getRBWorld()); + } + if( dynamicObject->second->getBRtype() == RB_Type_Sphere) + { + Oyster::Graphics::API::RenderDebugSphere( dynamicObject->second->getRBWorld()); + } + } + } + } // !RB DEBUG Oyster::Graphics::API::EndFrame(); @@ -487,7 +487,7 @@ const GameClientState::NetEvent & GameState::DataRecieved( const GameClientState if( !Within(position.Dot(position), 2500.0f, 90000.0f) ) { // HACK: bug trap const char *breakPoint = "Something is wrong."; - //position = Float3( 0.0f, 160.0f, 0.0f ); + position = Float3( 0.0f, 160.0f, 0.0f ); } this->privData->camera.SetPosition( position ); diff --git a/Code/Game/GameClient/GameClientState/NetLoadState.cpp b/Code/Game/GameClient/GameClientState/NetLoadState.cpp index b2475cc6..e3e453ad 100644 --- a/Code/Game/GameClient/GameClientState/NetLoadState.cpp +++ b/Code/Game/GameClient/GameClientState/NetLoadState.cpp @@ -154,7 +154,7 @@ void NetLoadState::LoadGame( const ::std::string &fileName ) { RBData.position = (Float3)oh->position + (Float3)oh->boundingVolume.box.position; RBData.rotation = ArrayToQuaternion( oh->rotation ); // Only model rotation - RBData.scale = (Float3)oh->scale * (Float3)oh->boundingVolume.box.size; + RBData.scale = (Float3)oh->scale * (Float3)oh->boundingVolume.box.size*2; RBData.type = RB_Type_Cube; staticObject->InitRB( RBData ); } @@ -163,7 +163,7 @@ void NetLoadState::LoadGame( const ::std::string &fileName ) { RBData.position = (Float3)oh->position + (Float3)oh->boundingVolume.sphere.position; RBData.rotation = ArrayToQuaternion( oh->rotation ); // Only model rotation - RBData.scale = (Float3)oh->scale * oh->boundingVolume.sphere.radius; + RBData.scale = (Float3)oh->scale * oh->boundingVolume.sphere.radius*2; RBData.type = RB_Type_Sphere; staticObject->InitRB( RBData ); } @@ -198,7 +198,7 @@ void NetLoadState::LoadGame( const ::std::string &fileName ) { RBData.position = (Float3)oh->position + (Float3)oh->boundingVolume.box.position; RBData.rotation = ArrayToQuaternion( oh->rotation ); // Only model rotation - RBData.scale = (Float3)oh->scale * (Float3)oh->boundingVolume.box.size; + RBData.scale = (Float3)oh->scale * (Float3)oh->boundingVolume.box.size*2; RBData.type = RB_Type_Cube; dynamicObject->InitRB( RBData ); } @@ -207,7 +207,7 @@ void NetLoadState::LoadGame( const ::std::string &fileName ) { RBData.position = (Float3)oh->position + (Float3)oh->boundingVolume.sphere.position; RBData.rotation = ArrayToQuaternion( oh->rotation ); // Only model rotation - RBData.scale = (Float3)oh->scale * oh->boundingVolume.sphere.radius; + RBData.scale = (Float3)oh->scale * oh->boundingVolume.sphere.radius*2; RBData.type = RB_Type_Sphere; dynamicObject->InitRB( RBData ); } diff --git a/Code/OysterGraphics/DllInterfaces/GFXAPI.cpp b/Code/OysterGraphics/DllInterfaces/GFXAPI.cpp index 89849f03..36cbfd54 100644 --- a/Code/OysterGraphics/DllInterfaces/GFXAPI.cpp +++ b/Code/OysterGraphics/DllInterfaces/GFXAPI.cpp @@ -221,6 +221,26 @@ namespace Oyster sphere->WorldMatrix = world; Render::DefaultRenderer::RenderScene(sphere,1,View,Projection); } +#else + API::State API::ReloadShaders() + { + + } + + void API::StartRenderWireFrame() + { + + } + + void API::RenderDebugCube(Math::Matrix world) + { + + } + + void API::RenderDebugSphere(Math::Matrix world) + { + + } #endif API::Option API::GetOption() diff --git a/Code/OysterGraphics/Shader/Passes/Light/SSAO.hlsli b/Code/OysterGraphics/Shader/Passes/Light/SSAO.hlsli index bf71b92b..f2258905 100644 --- a/Code/OysterGraphics/Shader/Passes/Light/SSAO.hlsli +++ b/Code/OysterGraphics/Shader/Passes/Light/SSAO.hlsli @@ -1,7 +1,7 @@ #include "Defines.hlsli" #include "PosManipulation.hlsli" -static float Radius = 100; +static float Radius = 10; float GetSSAO(float3 pos, float2 uv, int2 texCoord2, uint2 rndID) { @@ -41,7 +41,7 @@ float GetSSAO(float3 pos, float2 uv, int2 texCoord2, uint2 rndID) float sampleDepth = ViewPos.z; //compare to depth from sample - float rangeCheck = (abs(pos.z - sampleDepth) < Radius) ? 1.0f : 0.0f; + float rangeCheck = (abs(pos.z - sampleDepth) > Radius) ? 1.0f : 0.0f; occlusion += (sampleDepth <= sampled.z ? 1.0f : 0.0f) * rangeCheck; } occlusion /= (float)(SSAOKernel.Length.x); From 3527d3acb0059ab850d7015172abe73068095b34 Mon Sep 17 00:00:00 2001 From: Pontus Fransson Date: Thu, 20 Feb 2014 09:07:02 +0100 Subject: [PATCH 2/3] Network - Fixed memory leak in NetworkServer. --- Code/Network/NetworkAPI/NetworkServer.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Code/Network/NetworkAPI/NetworkServer.cpp b/Code/Network/NetworkAPI/NetworkServer.cpp index 028ca58e..7d1cbdc5 100644 --- a/Code/Network/NetworkAPI/NetworkServer.cpp +++ b/Code/Network/NetworkAPI/NetworkServer.cpp @@ -83,7 +83,13 @@ public: , broadcastTime(1.0f, 0.0f) { } ~PrivateData() - { } + { + if(listener) + { + delete listener; + listener = NULL; + } + } bool DoWork(); From d80dec600b4c9326c8065585fee27cdc164b189d Mon Sep 17 00:00:00 2001 From: Dander7BD Date: Thu, 20 Feb 2014 09:20:26 +0100 Subject: [PATCH 3/3] Memory leak dealt with + removed obsolete debug trap --- Code/Game/GameClient/GameClient.vcxproj.user | 2 +- Code/Game/GameClient/GameClientState/C_Object.cpp | 4 +++- Code/Game/GameClient/GameClientState/Camera_FPSV2.cpp | 5 ----- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Code/Game/GameClient/GameClient.vcxproj.user b/Code/Game/GameClient/GameClient.vcxproj.user index 2e28d6f7..4b847ee6 100644 --- a/Code/Game/GameClient/GameClient.vcxproj.user +++ b/Code/Game/GameClient/GameClient.vcxproj.user @@ -1,7 +1,7 @@  - true + false $(OutDir) diff --git a/Code/Game/GameClient/GameClientState/C_Object.cpp b/Code/Game/GameClient/GameClientState/C_Object.cpp index ccea9a86..50664a92 100644 --- a/Code/Game/GameClient/GameClientState/C_Object.cpp +++ b/Code/Game/GameClient/GameClientState/C_Object.cpp @@ -16,8 +16,10 @@ C_Object::C_Object() } C_Object::~C_Object() { - + if( this->model ) + this->Release(); } + bool C_Object::Init(ModelInitData modelInit) { position = modelInit.position; diff --git a/Code/Game/GameClient/GameClientState/Camera_FPSV2.cpp b/Code/Game/GameClient/GameClientState/Camera_FPSV2.cpp index 0cf4500d..14b16838 100644 --- a/Code/Game/GameClient/GameClientState/Camera_FPSV2.cpp +++ b/Code/Game/GameClient/GameClientState/Camera_FPSV2.cpp @@ -136,11 +136,6 @@ void Camera_FPSV2::StrafeLeft( Float distance ) void Camera_FPSV2::PitchUp( Float radian ) { - if( radian >= 0.5f ) - { // HACK: debugging - const char *breakPoint = ""; - } - this->pitchUp = Clamp( this->pitchUp + radian, -0.48f * pi, 0.48f * pi ); this->pitchHaveChanged = true; }